Skip to content

29 convert turret crt encoders to the wcp throughbore encoders#35

Merged
ImSpxrsh merged 29 commits intodevelopfrom
29-convert-turret-crt-encoders-to-the-wcp-throughbore-encoders
Feb 28, 2026
Merged

29 convert turret crt encoders to the wcp throughbore encoders#35
ImSpxrsh merged 29 commits intodevelopfrom
29-convert-turret-crt-encoders-to-the-wcp-throughbore-encoders

Conversation

@NathanEdg
Copy link
Member

Convert rev encoders into wcp encoders

NathanEdg and others added 23 commits January 28, 2026 16:26
…ebuilt into 13-turret-initial-code

# Conflicts:
#	src/main/java/frc/robot/subsystems/turret/Turret.java
#	src/main/java/frc/robot/subsystems/turret/TurretIOSensorInputs.java
# Conflicts:
#	src/main/java/frc/robot/CanID.java
#	src/main/java/frc/robot/RobotContainer.java
#	src/main/java/frc/robot/subsystems/vision/Vision.java
#	src/main/java/frc/robot/subsystems/vision/photon/Camera.java
…ic LowPassFilter, and added guardrails in the StateMachine
This reverts commit 1abef26.
This reverts commit 07ba2b5.
@NathanEdg NathanEdg requested review from a team February 26, 2026 18:51
@NathanEdg NathanEdg linked an issue Feb 26, 2026 that may be closed by this pull request
afranchuk
afranchuk previously approved these changes Feb 26, 2026
@PillageDev
Copy link
Member

Should probably change the merge target to the turret branch

@PillageDev PillageDev changed the base branch from develop to 13-turret-initial-code February 27, 2026 15:16
@PillageDev
Copy link
Member

Which I just did

* Add shooter subsystem with shot compensation logic and CAN ID updates

* Add shooter subsystem initialization in RobotContainer

* Refactor shooter and turret subsystems to use new Targeting subsystem and remove old pubsub system

* Integrate shooter and turret dependencies into indexer subsystem and enhance ball feeding logic
Base automatically changed from 13-turret-initial-code to develop February 28, 2026 19:26
@ImSpxrsh ImSpxrsh dismissed afranchuk’s stale review February 28, 2026 19:26

The base branch was changed.

Copy link
Member

@ImSpxrsh ImSpxrsh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@ImSpxrsh ImSpxrsh merged commit d1e7ba3 into develop Feb 28, 2026
2 checks passed
@ImSpxrsh ImSpxrsh deleted the 29-convert-turret-crt-encoders-to-the-wcp-throughbore-encoders branch February 28, 2026 20:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Convert turret CRT encoders to the WCP Throughbore encoders

5 participants